Make meetings wider, higher and add description #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for vedtatt ready! 🔨 Explore the source changes: 9423795 🔍 Inspect the deploy log: https://app.netlify.com/sites/vedtatt/deploys/619abc6db7631d0007320d0a 😎 Browse the preview: https://deploy-preview-291--vedtatt.netlify.app/ |
schjoth
requested changes
Nov 19, 2021
There was a problem hiding this comment.
Personally, I think these boxes are way too huge when no description is provided, because the boxes are almost only white space. But it looks great when you have a somewhat detailed description, and you are an admin.
With all this space, I think we at least should display the organization name as well.
Random suggestions:
- Display organization name next to the title in a less aggressive font, that wraps to the next line on mobile?
- Have the active/admin tags together at the right side next to title? (and have reverse-wrap so that the tags are displayed before the title on mobile)
…ntend into fix/update_meeting_design
kharann
reviewed
Feb 23, 2022
| @@ -94,17 +94,20 @@ const Meeting: React.FC< | |||
| <Heading as="h2" fontSize="1.5em"> | |||
| {title} | |||
| </Heading> | |||
| <Text fontSize="1em">{formatMeetingTime(new Date(startTime))}</Text> | |||
| <Box minH="2rem">{description && <Text>{description}</Text>}</Box> | |||
There was a problem hiding this comment.
This will show an empty div with 2rem even if description is missing. Is this intended? or should it be:
{description && <Box minH="2rem"><Text>{description}</Text></Box>}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.